-
Notifications
You must be signed in to change notification settings - Fork 223
psbt: add MuSig2 fields #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fc57dfb
to
46ceff9
Compare
I ended copying @bigspider's code. However there's no test coverage. I also can't manually test it on a device without passing the BIP-388 policy policy and (no BIP?) HMAC, which is a separate issue. |
Fixed a few bugs. I wanted to test this using #792 and taking some code from MooSig, but the latter changed the |
I think I get the gist of the |
I've been testing this with various wallets and I'm pretty sure it works now. Rebasing on #795 to make sure CI passes. |
f35fe9f
to
337fd14
Compare
Fixed linter Looks like I accidentally dropped I also added the new test vectors, copied from Bitcoin Core. |
Co-Authored-By: Salvatore Ingala <[email protected]>
Rebased after #795 landed. |
Fixes #783